Return the length of the longest stream in AudioStreamRandomizer #105954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mickeon
changed the title
Mickeon
force-pushed
the
AudioStreamRandomizer-has-length
branch
from
defff7e to
3fce22d
Compare
|
Closed as #105952 has been discussed to be preferable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #105929
Fixes #104684
Currently, AudioStreamRandomizer's
get_length()returns0.0, meaning the engine essentially thinks the length cannot be obtained. This is somewhat silly in hindsight.This PR makes it so that the longest... length out of the available streams in the AudioStreamRandomizer is chosen, thus allowing AudioStreamInteractive to work with it, as well.
From there, it is up to the developer to ensure all random streams are roughly the same length, in order to avoid awkward silence.
As of writing this has not been tested just yet. It may need to be documented as well.