-
-
Notifications
You must be signed in to change notification settings - Fork 22.8k
Move MovieWriterMJPEG class to jpg
module it depends on
#106013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move MovieWriterMJPEG class to jpg
module it depends on
#106013
Conversation
6b35f26
to
de31031
Compare
I have a PR that aims to address this, but I ran into an issue: #95867
We can probably reuse the "no default scene has been configured" dialog's code for this. Edit: I have a WIP branch that aims to do this, but I get a crash when the dialog appears (I don't know why, the backtrace doesn't tell me much): https://github.com/Calinou/godot/tree/editor-moviewriter-ask-for-movie-file Edit 2: This was addressed by #106231, with the exception of the text alignment in the alert dialog. |
de31031
to
0bec705
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, it works as expected. Code looks good to me.
I've tested a build with module_jpg_enabled=no
and it correctly disabled MovieWriterMJPEG.
0bec705
to
78eb0b6
Compare
MovieWriterMJPEG
doesn't work withmodule_jpg_enabled=no
#90932.MovieWriterMJPEG
when jpg module is disabled #100166.Draft as it includes Use libjpeg-turbo for improved jpg compatibility and speed #104347 to avoid conflicts, I'll rebase once it's merged.I don't intend to work on it further, but there are various UX issues I noticed which may be worth addressing (@Calinou):
.avi
extension with the jpg module disabled, and likely already before when using any other extension than.avi
or.png
, the movie writer doesn't give any warning and starts, but prints an error:It should probably validate that the file type is supported before running the project in movie writer mode, showing explanations to the user with a popup.
When no movie writer write path is configured, the following dialog is shown. It has multiple UX issues.

editor/movie_writer/movie_file
project setting.res://
).The expectation to select the output format (avi or png) just based on the file extension, with the only information available in the documentation for the project setting, is suboptimal. In the future, such features might be better served with a dedicated dialog (similar to the "Customize Run Instances..." dialog) that lets users configure all the settings for encoding.