Move MovieWriterMJPEG class to jpg
module it depends on
#106013
+33
−21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MovieWriterMJPEG
doesn't work withmodule_jpg_enabled=no
#90932.MovieWriterMJPEG
when jpg module is disabled #100166.Draft as it includes Use libjpeg-turbo for improved jpg compatibility and speed #104347 to avoid conflicts, I'll rebase once it's merged.I don't intend to work on it further, but there are various UX issues I noticed which may be worth addressing (@Calinou):
.avi
extension with the jpg module disabled, and likely already before when using any other extension than.avi
or.png
, the movie writer doesn't give any warning and starts, but prints an error:It should probably validate that the file type is supported before running the project in movie writer mode, showing explanations to the user with a popup.
When no movie writer write path is configured, the following dialog is shown. It has multiple UX issues.

editor/movie_writer/movie_file
project setting.res://
).The expectation to select the output format (avi or png) just based on the file extension, with the only information available in the documentation for the project setting, is suboptimal. In the future, such features might be better served with a dedicated dialog (similar to the "Customize Run Instances..." dialog) that lets users configure all the settings for encoding.