Fix Windows OS.get_unique_id() null termination issue
#106052
+8
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
changed the title
OS.get_unique_id() null termination issue
uno1982
force-pushed
the
correct-get_unique_id-windows-null-termination
branch
from
21f05d2 to
eab57c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #106012
It appears the function return from the windows API included a null termination?
I've commented this specific segment of code with a safety to handle this.
There was quite a bit of changes between 4.4 and 4.5-Dev around print() and print_rich() that created some difficulty in hunting the exact cause of the editor output hang while the console exe continued to function
This fix addresses the length, output and concat, issues.
Before:
After:
