Fix creating outline for skinned meshes #106076
Conversation
akien-mga
changed the title
|
Hello! Thanks for contributing. I assigned animation maintainers for review as they're most familiar with mesh skinning. A small form nitpick: The commit message should be amended to be a proper sentence in English (like I did with the PR title). See https://github.com/godotengine/godot/blob/master/CONTRIBUTING.md#format-your-commit-messages-with-readability-in-mind and PR workflow for details on how to format and amend commits. |
TheoLomeuBraga
changed the title
TheoLomeuBraga
changed the title
sorry i'm new to this |
| @@ -542,6 +542,13 @@ void MeshInstance3DEditor::_create_outline_mesh() { | |||
|
|
|||
| MeshInstance3D *mi = memnew(MeshInstance3D); | |||
| mi->set_mesh(mesho); | |||
|
|
|||
| Node *skeleton = node->get_node(node->get_skeleton_path()); | |||
There was a problem hiding this comment.
This seems ok, we have a new MeshInstance3D and we either use the existing path or assume that it's the parent node (as a skeleton3d).
Closes #106074
now creating an outline mesh for a mesh with skim property will share the skim and skeleton properties for the outline mesh