Fix ghost collisions in segment_intersects_convex() #106084
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kaleb-Reid
force-pushed
the
fix-geometry-3d
branch
from
8e2744f to
ab313cd
Compare
Kaleb-Reid
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
segment_intersects_convex()ignored planes with a normal orthogonal to the direction of the segment. This is because they cannot intersect. However, if the points are above the plane then that means the plane is separating and the segment cannot intersect the convex hull.The line segment on the left shows the intersection previously reported by the function, because the plane facing it has an orthogonal normal vector and is ignored (Ignore the unrelated segment on the right originating from inside the cube).
I think this fixes #69455 but I cannot fully confirm that the original issue is solved by this as it's pretty vague and I had problems running the mrp.