Skip to content

ENet: Expose the check_events method to GDScript #106112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

coffeebeats
Copy link

ENetConnection::check_events was added in #53129 but was not exposed to GDScript. This pull request exposes it to GDScript so that users of the low-level networking API (i.e. ENetConnection) can correctly process events within a tick.

Fixes godotengine/godot-proposals#12376.

@coffeebeats coffeebeats requested review from a team as code owners May 5, 2025 23:09
@coffeebeats
Copy link
Author

coffeebeats commented May 6, 2025

Question for reviewers:

This change (and the code in ENetConnection::_service) depends on an Array constructor present in master for a year. However, I see that the 4.4 branch uses a different Array construction method.

Why is this? If this PR is accepted, do I need to backport it to something compatible with 4.4/4.5?

Edit: Nevermind, I see that the pull request which introduced the new Array constructor (#86015) was actually just merged and is slated for 4.5.

@akien-mga akien-mga changed the title ENet: expose the check_events method to GDScript ENet: Expose the check_events method to GDScript May 6, 2025
@akien-mga akien-mga added this to the 4.x milestone May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose ENetConnection::check_events (enet_host_check_events) to GDScript
2 participants