Improve zoom performance in Script and Shader editors
#106117
+27
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaydensipe
force-pushed
the
zoom-performance-smoooooth
branch
from
9ccb3e2 to
e0569c7
Compare
jaydensipe
force-pushed
the
zoom-performance-smoooooth
branch
from
e0569c7 to
0c5c3e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the zoom performance when you have multiple (previously) opened scripts in the script/shader text editors. This was done by deferring the expensive
set_zoom_factor(and subsequent cache invalidation) function calls to only be called when you open a script.This was previously updated N * scroll wheel spins times for each script you had opened; this was done to keep the zoom percentage in sync between scripts, but is now updated and stored in the script/shader editor plugins instead.
Warning
Zooming can still stutter on bigger and/or first-time opened scripts due to cache invalidation within that single code editor instance. Further work could be done to improve this.
Screen.Recording.2025-05-06.024642.mp4
Screen.Recording.2025-05-06.024518.mp4