Fix tests that fail when alone #106129
Merged
Fix tests that fail when alone #106129
+8
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
May 7, 2025
|
|
||
| TEST_CASE("[Modules][GDScript] Load source code dynamically and run it") { | ||
| GDScriptLanguage::get_singleton()->init(); |
There was a problem hiding this comment.
Does this solve the TODO on line 39?
There was a problem hiding this comment.
No, the Script compilation and runtime test still fails, and it only fails in template/release builds unlike these ones which fail when alone.
Unfortunately it is more complex to fix.
akien-mga
approved these changes
May 7, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain tests fail when by themselves, since they depend on other tests.
Use these args to test:
--test --tc="[ProjectSettings]*",--test --tc="[Modules][GDScript] Load source code dynamically and run it"I tested on release build and this seems to fix the issues from #88452 for these 3 tests, the other one still has an issue in non-editor builds.
For
[ProjectSettings] Get existing settingand[ProjectSettings] Default value is ignored if setting exists, they expect to be ran after the[Modules][GDScript]Script compilation and runtimetest, which modifies the ProjectSettings.I changed them to use a different project setting that was untouched by that test.
For
[Modules][GDScript] Load source code dynamically and run it, the GDScript fails during compilation with an errorCompile Error: GDScript bug (please report): Native class "RefCounted" not found..This is because the language wasn't initialized for this test.