[.NET] Avoid heap alloc when using StringNames as key in a Dictionary #106133
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StringNames
in Godot C# are IEquatable, and overridesGetHashCode()
, which callsgodot_string_name.movable
's version of that method, which was not overridden. This led to heap allocations when e.g. calling the indexer in a Dictionary withStringName
type as Key.This PR just adds the (assuming) missing method, which seems to fix the issue.