-
-
Notifications
You must be signed in to change notification settings - Fork 22.3k
macOS: Additional improvements and fixes for embedded window support #106134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
macOS: Additional improvements and fixes for embedded window support #106134
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, it works as expected. Code looks good to me.
I can confirm the mouse capture issues I mentioned in the original PR are gone. I've also checked that the single window mode makes the warning message appear correctly (and disables the feature).
Note that I still can't close the game by pressing the X button when game embedding in a floating window is enabled though. I can do that when game embedding is disabled.
Thanks! |
Thanks @Calinou. I'm working on the following items, which weren't included in this:
|
Hi @stuartcarnie, Screen.Recording.2025-05-07.at.18.42.39.mov |
Are you running any special settings for your display? Is it a high-DPI display? I have been unable to reproduce that – though it was an issue in much earlier builds. If you can create an MRP, that would help. |
My display is 2560x1080 ultrawide. Would sending you my personal Project.godot help? |
Yes, your personal |
This PR includes the following PR feedback and improvements for #105884
--embedded
is all that is required, and works like an alias to--display-server embedded
.