Fix filename_filter property
#106135
Open
Fix filename_filter property
#106135
+8
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
May 7, 2025
Comment on lines
1600
to
+1602
| filename_filter->grab_focus(); | ||
| } else { | ||
| file_name_filter.clear(); |
There was a problem hiding this comment.
Oof, there's filename_filter and file_name_filter in this class...?
There was a problem hiding this comment.
Yeah, it confused me a lot while trying to make my own PR, which eventually led me to give up
I was literally going insane because of this lmao
There was a problem hiding this comment.
Oh how nice having to deprecate properties added just a single version ago
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #104067
Supersedes #104492
The
filename_filterproperty is now editable. Setting it to a non-empty String will automatically press the filter button to show the LineEdit. Unpressing the button still clears the filter.tbh I'd just remove (unexpose) this property, there are many questionable things about its implementation. This PR at least makes it somewhat usable.