Remove redundant line_spacing editor setting
#106137
Merged
+2
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mickeon
reviewed
May 7, 2025
Mickeon
approved these changes
May 7, 2025
There was a problem hiding this comment.
There's not even any ambiguity here. Both settings sound like they should do the same thing. It feels like one was kept by accident, and judging by the vague grouping, text_editor/theme/line_spacing is the accident.
We should reevaluate a lot of editor settings, in my opinion.
|
Note, though. The default of the removed setting was |
RedMser
force-pushed
the
remove-unused-linespacing-setting
branch
from
e4ebd0c to
4acdc7a
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The setting
text_editor/theme/line_spacingwas only used in this one code location.Meanwhile,
text_editor/appearance/whitespace/line_spacingis used everywhere else.Seems best to just merge them and remove the one that only affects the native shader code viewer :D
Code changes are untested... 🙏