Fix unexpected control position change when left/top offsets not match pos_cache #106141
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
L2750558108
changed the title
L2750558108
force-pushed
the
fix-control-position
branch
from
d4dfd67 to
49c7966
Compare
|
It fixes the regressions, but it might introduce a new one, just like the previous fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #104357, in order to prevent the size of the offsets from being broken during offsets recalculate in set_position, the rect which use size calculated in real time via the offsets (previously use size_cache) is used when the offsets are recalculated in set_position.
But this doesn't take into account the position of the rect. If the current pos_cache does not match (edge[0], edge[1]) calculated via offsets (e.g. the control's size is propped up by the minimum size when the grow_direction is not Right/Bottom), the position of the control may be offset to the top left of the expected position. This pr solve this
Fixes : #105771