-
-
Notifications
You must be signed in to change notification settings - Fork 22.8k
Linux: Fix build with dbus=no
or threads=no
#106175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BTW, I found this while testing an editor build with Overall using the editor single-threaded on desktop is not really a use case we want to actively support, but if we can make it build without too much hassle, it's a convenient way to test behavior for the single-threaded web editor on desktop. |
Same for |
The Wayland backend depends on a thread for its event handling, should it check for that too? Edit: I think that the X11 backend also handles certain events in a thread. |
Windows and macOS display servers use threads as well, not sure if this flag is meaningful for anything except Web. |
bc9cc62
to
e9e8ddc
Compare
It's not, as I mentioned above. But it used to compile and work fine as of #85939, and it's useful occasionally to test how the editor behaves on a single-thread without having to use the Web Console for debugging, which is less convenient than a native app/debugger. It's not meant to be a supported configuration but if it's not hard to keep it working, I see no harm in doing so. For Windows/macOS, I agree we can just ignore it. I've amended the commit to disable |
dbus=no
dbus=no
or threads=no
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, it works as expected. Tested locally, it works as expected. I've used a threads=no
editor to open and run some demo projects.
No description provided.