Inline static variables (part 2) #106293
Open
Inline static variables (part 2) #106293
+120
−346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoBeWi
commented
May 11, 2025
Comment on lines
+40
to
+50
| D3D12Hooks() { | ||
| if (singleton == nullptr) { | ||
| singleton = this; | ||
| } | ||
| } | ||
|
|
||
| virtual ~D3D12Hooks() { | ||
| if (singleton == this) { | ||
| singleton = nullptr; | ||
| } | ||
| } |
There was a problem hiding this comment.
This might be questionable, but these are very simple and were the only thing in the cpp file, so it could be removed...
There was a problem hiding this comment.
I don't think removing .cpp files is a goal, but having this in the .h file certainly isn't wrong either. I think it's fine :)
KoBeWi
force-pushed
the
transitory_interline
branch
from
e849f5f to
8a3f585
Compare
KoBeWi
force-pushed
the
transitory_interline
branch
from
8a3f585 to
955cafa
Compare
|
Why does this fail checks?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #105876