Skip to content

Remove "prioritize master" comment on PRs #106351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
adamscott wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove "prioritize master" comment on PRs #106351

adamscott wants to merge 1 commit into from
+0 −4

Conversation

@adamscott
Copy link
Member

@adamscott adamscott commented May 13, 2025

Removes a remnant developing 4.0 pre-release.

Capture d’écran du 2025-05-13 07-56-28

@adamscott adamscott added this to the 4.5 milestone May 13, 2025
@adamscott adamscott requested a review from a team as a code owner May 13, 2025 11:59
Calinou
Calinou approved these changes May 13, 2025
View reviewed changes
Copy link
Member

@Calinou Calinou left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. We still want PRs to be opened on master whenever possible, but nearly all PRs opened in the last few months follow this rule already.

@clayjohn
Copy link
Member

clayjohn commented May 13, 2025

I don't understand why this needs to be removed? Don't we want people to target master still? IIRC this was added because people kept opening PRs against specific branches

@Repiteo Repiteo modified the milestones: 4.5, 4.x Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Calinou Calinou Calinou approved these changes

@akien-mga akien-mga akien-mga approved these changes

Assignees

No one assigned

Labels

discussion enhancement topic:buildsystem usability

Projects

None yet

Milestone

4.x

Development

Successfully merging this pull request may close these issues.

5 participants

@adamscott @clayjohn @Calinou @akien-mga @Repiteo