Fix fade out duration to extend a bit take into account current delta in NodeOneShot #106567
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TokageItLab
changed the title
TokageItLab
changed the title
TokageItLab
force-pushed
the
fix-fadeout-dur
branch
from
0320305 to
2ffb3fb
Compare
|
I was able to build and test the MRP from the issue against this PR and it does solve the problem. I agree that there is an off by one error and a simple one liner fix is all that's needed. I can test it against a more complicated animation tree if given more time, but it seems to fix the issue. As mentioned in my PR I'm not very familiar with the animation code, so I don't think I can give a quality review, but I'll close that one in favor of this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NodeOneShotfading to uses self delta instead of input delta #101792AnimationNodeOneShotfails to triggeranimation_finishedsignal at high frame rates. #103070AnimationNodeOneShotduring fade-out to ensure signal fires #103078I think the cause of the issue is that the delta is subtracted immediately, so the fadeout duration is shortened by one frame. This may be a bit of a hack, but it can be solved by extending the duration by delta which will be subtracted in advance.