Skip to content

Fix animation track subpath hint inference. #106580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SaracenOne
Copy link
Member

@SaracenOne SaracenOne commented May 19, 2025

Attempts to fix the issue by removing the bezier hack and handling it in a more elegant way based on @YuriSizov's suggestion #102130 (comment)

I think this should be correct now, but another pair of eyes on this would be appreciated.

@SaracenOne SaracenOne marked this pull request as draft May 19, 2025 02:31
@SaracenOne SaracenOne force-pushed the animation_track_type_hint_fix branch from 0e1811a to 0b2a84b Compare May 19, 2025 02:32
@SaracenOne SaracenOne marked this pull request as ready for review May 19, 2025 02:34
@TokageItLab TokageItLab requested a review from a team May 19, 2025 04:49
@YuriSizov
Copy link
Contributor

YuriSizov commented May 19, 2025

Hey, thanks for working more on this! To be clear, I was talking specifically about this change (and the one before it that introduced Variant value = p_node->get(p_property);):

Which I think is still in effect as of this PR:

// Get the value from the subpath.
Variant value = p_node;
Vector<String> property_path = p_property.split(":");
for (const String &E : property_path) {
if (value.get_type() == Variant::OBJECT) {
Object *obj = value;
value = obj->get(E);
} else {
value = Variant();
break;
}
}

Though I didn't look too deep into the issues and might've misattributed the cause, I still think that piece needs to be changed. If for nothing else but to avoid inventing ad hoc solutions when there is already one in the engine 🙂

@akien-mga akien-mga added the cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release label May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release regression topic:animation topic:editor topic:gui
Projects
None yet
3 participants