-
-
Notifications
You must be signed in to change notification settings - Fork 22.4k
Audio stream synchronized refactoring and prevent stream sync from stopping when set #106608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
adriano-sudario
wants to merge
26
commits into
godotengine:master
Choose a base branch
from
adriano-sudario:audio-stream-synchronized-refactoring-and-prevent-stream-sync-from-stopping-when-set
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+394
−135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I opened PR #100534 a while ago, but messed up after a rebase, so setted it as draft to be removed, but the description still applies to this one.
I think this PR still needs some discussion, but I believe it's important to take a look at that so AudioStreamSynchronized doesn't become a forgotten feature with no maintenance. Same applies to AudioStreamInteractive (to be discussed later), which I believe also needs some refactoring, but this PR doesn't cover nothing on that regard.
Besides the changes on the previous PR, this one also adds unit tests to make sure the refactoring didnt break anything.
Here's some points that needs to be addressed on the discussion:
That's it for this PR, please be welcome on joining discussion or just let me know if it doesn't make sense.