Fix Dictionary::operator[] from C++ accidentally modifying const dictionaries.
#106636
+14
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dictionaries. Fix `AudioStreamWav` inserting keys into the input dictionary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dictionary(and possiblyArrayandNodePath). #106600This fixes a long standing subtle bug where
Dictionarycan be accidentally modified onconstoperator[]subscript.Since #106600 might take a while longer to merge (since it introduces a new type to bikeshed over), I thought it may be appropriate to PR the most important fix separately, so we have time to work through possible regressions.