Skip to content

Conversation

@arkology
Copy link
Contributor

Attempt to resolve godotengine/godot-proposals#12052

godot.windows.editor.dev.x86_64_MGoiltojRG.mp4

@arkology arkology requested review from a team as code owners May 24, 2025 19:54
@KoBeWi KoBeWi added this to the 4.x milestone May 25, 2025
@KoBeWi
Copy link
Member

KoBeWi commented Jun 15, 2025

The button has wrong pressed style:
image
Also reparenting feels a bit hacky. I think it would be fine if the button was duplicated, then you could just toggle visibility. Only the visible button can process shortcut, so it should work properly.
EDIT:
I guess syncing the state of buttons would become a problem.

@arkology arkology force-pushed the no-more-distraction branch from ef61153 to bc625a4 Compare June 16, 2025 10:34
@arkology
Copy link
Contributor Author

@KoBeWi button theme should be fixed now.
As I mentioned in feature proposal, I'm not a big fan of my implementation, but it is functional and not very overengineered (IMO).
Any suggestions are welcomed. If I understood your comment correctly, creating a duplicate of this button and trying to synchronize its state is also a hacky solution, and it also makes no sense to consider this option, right?

Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solution is ok.

We don't have any simple way to sync pressed state of 2 buttons (there is ButtonGroup, but for basically an opposite use-case), so any solution would likely involve hacks.

@KoBeWi KoBeWi modified the milestones: 4.x, 4.6 Jun 16, 2025
@arkology arkology force-pushed the no-more-distraction branch from bc625a4 to f3781c5 Compare June 17, 2025 07:41
@arkology arkology requested a review from a team as a code owner September 25, 2025 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add "Distraction Free Mode" button to EditorBottomPanel when bottom panel is expanded

3 participants