Improve Input Map and Shortcuts editor - #107196
Merged
Merged
Conversation
KoBeWi
reviewed
Jun 6, 2025
timothyqiu
force-pushed
the
events-improvements
branch
from
June 6, 2025 14:21
fa98ae3 to
9c04dac
Compare
KoBeWi
reviewed
Jun 6, 2025
timothyqiu
force-pushed
the
events-improvements
branch
from
June 6, 2025 16:43
9c04dac to
3e965e6
Compare
KoBeWi
reviewed
Jun 6, 2025
KoBeWi
approved these changes
Jun 6, 2025
timothyqiu
force-pushed
the
events-improvements
branch
from
June 7, 2025 02:51
3e965e6 to
dbd15ea
Compare
- Fixes not being able to search by pressing ESC. - Removes double translations. - Cleans up `InputEventConfigurationDialog` for auto-translation. - Adapts to editor theme change. - Unifies search bar boilerplate code. - Shortcuts: disable the "erase" button if there is no event to remove. - Input Map: always include built-in actions when searching.
timothyqiu
force-pushed
the
events-improvements
branch
from
June 7, 2025 09:52
dbd15ea to
146599d
Compare
AThousandShips
approved these changes
Jun 7, 2025
Member
|
Thanks! |
BendyLand
pushed a commit
to BendyLand/voltaire
that referenced
this pull request
Aug 2, 2026
…ents Improve Input Map and Shortcuts editor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InputEventConfigurationDialogfor auto-translation.child_node->get_theme_xxx()inNOTIFICATION_THEME_CHANGEDinstead of calling the method directly. This redirection is not only redundant but also returns cached old values since the child nodes have not yet received the notification at that time.