Fix removing wrong vertices in the Polygon2D editor when points overlap each other #107932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nikitf777
force-pushed
the
polygon2d-editor-fix-remove-order
branch
from
9ab0e6e to
83aa9cf
Compare
KoBeWi
approved these changes
Jun 30, 2025
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on my previous PR #107890 I noticed that the editor can sometimes remove a point, that is "behind" the point that you actually point on:
wrong-point-is-removed.mp4
This PR fixes it. Now the remove action uses a more intuitive logic to choose which vertex to remove, and its logic now the same, as the move action uses:
fixed-remove-order.mp4