CodeEdit: Add line number gutter minimum digits

[timothyqiu]

The problem: When editing scripts, I often notice this kind of jump caused by line numbers.

This PR:

• Adds a line_numbers_min_digits property to CodeEdit. It defaults to 1 to be compatible with existing projects.
• Adds an editor setting text_editor/appearance/gutters/line_numbers_min_digits which defaults to 2.

[Mickeon]

For reference, and from what I can see, in terms of what other programs do:

• Visual Studio Code has a minimum width of 4. This cannot be customized.
• Notepad++ has a minimum width of 3 if the "Line Number" is set to "Dynamic width", otherwise it's 4.
• Github's online text editor has no minimum width.

Given that some scripts can genuinely be really brief and self-sustaining, a minimum width of 2 by default in this PR may sound ideal. However, I would say that for any practical purposes most scripts will easily reach 3 digits, so that would be more ideal in my opinion.

I also would not make this an editor setting, personally, unless there's severe demand for it, because it's far too niche. A property or theme item may be fine, however.
Even if you disagree, the current range (up to 10 or even greater) is absolutely ridiculous for many reasons, but let's also keep in mind that the existing text editor already struggles with horizontal space, which makes the need to increase this number even more unlikely.

[timothyqiu]

• Changed the range hint to 1,5,1.
• Changed the editor setting's default to 3.

I also would not make this an editor setting, personally, unless there's severe demand for it, because it's far too niche. A property or theme item may be fine, however.

There may be some misunderstanding here. This PR adds a property to the CodeEdit node. The CodeTextEditor in the editor uses CodeEdit and applies the editor setting to it.

[Mickeon]

No misunderstanding. I am aware of what this PR does. I just think an editor setting is excessive.

[Calinou]

Tested locally, it works as expected. I think this is a good usability improvement, not only when editing code, but also when switching between scripts.

That said, in complex projects, the majority of GDScript files are expected to be in the 100-999 line range. Therefore, I don't think we need to expose an editor setting for this. A lower value would save a tiny bit of horizontal space in projects that use lots of small scripts, but you'd reintroduce the issue with layout shifts on script change as soon as you even have one script with 100+ lines of code.

[Mickeon]

I am neutral on the actual property itself. I think it makes sense, but I've never seen it being suggested until now. I approve for the editor's usability.

[akien-mga]

Adds a line_numbers_min_digits property to CodeEdit. It defaults to 1 to be compatible with existing projects.

IMO this would be fine to default to 3 too. It changes behavior slightly, but users who want to keep the former behavior can set the property to 1 themselves. I think the default behavior should be to minimize these jumps.

[Mickeon]

Alright then, but let's remember to document it in the migration guide.

[timothyqiu]

How about this?

When a node is created in the editor (e.g., via the Create dialog), assign more appropriate values to the node's properties. This ensures existing projects remain unaffected.

For example, this method is used to assign properties marked with PROPERTY_USAGE_EDITOR_INSTANTIATE_OBJECT a new resource instance after the node / resource is created in the editor. We can repurpose / rename it to also set saner default values.

godot/editor/editor_data.cpp

Lines 595 to 607 in 0fdbf05

	void EditorData::instantiate_object_properties(Object *p_object) {
	ERR_FAIL_NULL(p_object);
	// Check if any Object-type property should be instantiated.
	List<PropertyInfo> pinfo;
	p_object->get_property_list(&pinfo);
	for (const PropertyInfo &pi : pinfo) {
	if (pi.type == Variant::OBJECT && pi.usage & PROPERTY_USAGE_EDITOR_INSTANTIATE_OBJECT) {
	Object *prop = ClassDB::instantiate(pi.class_name);
	p_object->set(pi.name, prop);
	}
	}
	}

Since these classes and their "default values" are listed in a centralized location, it also acts as a tracker. It'll be easier to make them the default in the next compat-breaking release.

[timothyqiu]

Updated and just changed the default to 3.

[Repiteo]

Thanks!