Skip to content

Conversation

@Kiisu-Master
Copy link
Contributor

@Kiisu-Master Kiisu-Master commented Nov 1, 2025

fixes #64296
Note: I have no idea if how i did things is correct, this is my second time working with c++ and godot source.
I just tried to follow how things were done in the surrounding code.

Tested on latest kwin plasma 6.5.1

@Kiisu-Master
Copy link
Contributor Author

It seems the commit hash in thirdparty/README.md for wayland-protocols didn't get updated here ae74c0c

I just copied the pointer warp xml file from the main branch, should i include the one from 1.45 if its different?

@deralmas
Copy link
Contributor

deralmas commented Nov 2, 2025

I just copied the pointer warp xml file from the main branch, should i include the one from 1.45 if its different?

Yea, as wayland-protocols is at that version. If the protocol is not available there feel free to make a PR updating it.

Copied this code from pointer_set_hint, should there be a function to remove the duplicate scaling code?

Nah, it's done in only two places now and it's something that we should generally not do, as pointed out by the big comment.

What about the comment?

Not sure tbh. I'll be fair, in these cases I just keep them there, duplicated. You never know if the other half will be there by the time you'll need to read that comment again :P

@Kiisu-Master Kiisu-Master marked this pull request as ready for review November 3, 2025 20:42
@Kiisu-Master Kiisu-Master requested review from a team as code owners November 3, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

modifiying mouse position doesn't work (Linux Wayland)

3 participants