Fix cannot edit property material for new Instance PackedScene

[xuhuisheng]

• Fixes: All properties are disabled on a PackedScene node #112013

Issue Description

When we create a new instance PackedScene, then create a new Material for this embedded node. The properties of the new material will all read-only, until we save and reopen the scene.

The reason is EditorResourcePicker try to get scene_path from node to locate the resource of material. But embedded node returns its own scene_path, which is different from root scene_path.

godot/editor/inspector/editor_resource_picker.cpp

Lines 643 to 646 in 0fdbf05

	if (node) {
	if (node->get_scene_file_path().is_empty()) {
	node = node->get_owner();
	}

The inspector determines we cannot edit embedded scene's property, then mark them as read-only. After saving and reopening scene, the relevant scene path will be corrected, so we can edit these properties.

godot/editor/inspector/editor_inspector.cpp

Line 3886 in 0fdbf05

all_read_only = EditorNode::get_singleton()->is_resource_read_only(res);

Solution

We can use the root scene path of editing scene, when current node path is different.

material.webm

[KoBeWi]

This is unlikely under normal circumstances, but the scene might not exist. You should check whether root is not null before getting path.

[KoBeWi]

Suggested change

	// PackedScene should use root scene path
	// PackedScene should use root scene path.