Skip to content

Conversation

@YeldhamDev
Copy link
Member

As per @passivestar's recommendation (#112258 (comment)), this changes the default base color from #252525 to #272727, and the contrast from 0.3 to 0.35.

@DeeJayLSP
Copy link
Contributor

DeeJayLSP commented Nov 3, 2025

Unpopular opinion but, like in the comment I wrote for the main PR in which I compared main colors of other engines + popular what if neutral popular color themes, I would suggest bumping it up a bit more to #292929:

PR #292929 #292929 with contrast 0.37
image image image

PR feels good regardless.

@passivestar
Copy link
Contributor

@DeeJayLSP it's hard to say without using it for some time. Staring at this theme for 2 years gave me a lot of time to do a bunch of micro-adjustments to different controls, and stretching all values further into grays without looking at it for more than a couple of times is a bit risky because if some elements aren't getting multiplied by contrast properly it'll take time to notice.

It's also been tested and approved by people as a mostly dark theme, given that godot has both flexible customization controls for base color and contrast, as well as "light" and "gray" color presets (defaults for which could also be tweaked), I think it makes more sense to keep this theme more on the "dark" side.

So I'm not saying that your opinion is wrong, but rather that I just have more confidence in these values.

@Repiteo Repiteo merged commit 90659c1 into godotengine:master Nov 3, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 3, 2025

Thanks!

@YeldhamDev YeldhamDev deleted the modern_contrast_change branch November 3, 2025 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The tabs selected in the new editor theme are less visible Lower contrast in modern theme

5 participants