Fix compiling Godot for Linux failing with profiler_sample_callstack=yes
#114001
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
approved these changes
Dec 15, 2025
Repiteo
approved these changes
Dec 15, 2025
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #114000.
The issue is that
/core/profiling/SCsubchecks whether the current platform is calledlinux, which will fail, because it is calledlinuxbsd.Important: According to the support chart callstack sampling is actually not supported on BSD, unlike Linux. I don't have an installation of BSD, so I can't check whether my fix would causes issues on that platform. Although you could just not use the flag on that platform of course.