Fix EditorSetting presets cannot be set from code #114005
Open
+175
−128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some EditorSettings don't update correctly from code.
All settings that are part of presets don't work correctly since they don't set the preset to
Custom, and the value gets updated by the preset.This is mainly theme settings, it includes
interface/theme,text_editor/theme,editors/visual_editors/color_theme, andeditors/3d/navigation/navigation_scheme.Setting the presets themselves works, except for
navigation_scheme.For example, setting
"interface/theme/accent_color"in an EditorScript will not change the color (Unless theinterface/themeis already set toCustom).Now the presets are updated in EditorSettings instead of just in the dialog.
Also moved navigation preset code to the node3d editor.
I plan to do more fixes with the presets in another PR.