-
-
Notifications
You must be signed in to change notification settings - Fork 23.8k
Expose EditorExport
#114028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Expose EditorExport
#114028
Conversation
b45ff7b to
3785df3
Compare
3785df3 to
6ae5153
Compare
| Vector<Ref<EditorExportPlugin>> export_plugins; | ||
|
|
||
| static inline StringName _export_presets_updated; | ||
| static inline StringName _export_presets_runnable_updated; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are these changes for? They seem unrelated and would be good to document why
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, previously, some checks failed, I thought it was because of this, but if this is not the case, I can reverse it
https://github.com/godotengine/godot/actions/runs/20224035405
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably something incorrect with the usage, but that's okay, I think it's because of the order of creation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AThousandShips
Here are the errors after reverting the last change
ERROR: Class 'EditorExport' already has signal ''.
at: (core\object\class_db.cpp:1402)
ERROR: Class 'EditorExport' already has signal ''.
at: (core\object\class_db.cpp:1402)
ERROR: In Object of type 'EditorExport': Attempt to connect nonexistent signal 'export_presets_runnable_updated' to callable 'EditorExportPlatformAndroid::_update_preset_status'.
at: (core\object\object.cpp:1606)
ERROR: In Object of type 'EditorExport': Attempt to connect nonexistent signal 'export_presets_updated' to callable 'ProjectExportDialog::_force_update_current_preset_parameters'.
at: (core\object\object.cpp:1606)
6ae5153 to
43a5b0c
Compare
|
@AThousandShips I know 4.6 is feature freeze, but is it possible to merge this? It's not a very big change. I need this change, and I don't want to use a custom build for my team work, and I don't want to wait for 4.7 |
|
I have some random crashes |
|
This will not be merged in 4.6, you can build it for your own branch though, but if it is approved it won't be available until 4.7 at the earliest |
Resolves godotengine/godot-proposals#13865