[MacOS] Fix non-deterministic framework linking order on macOS for incremental builds - #114327
Merged
Repiteo merged 1 commit intoMar 19, 2026
Conversation
stuartcarnie
approved these changes
Mar 19, 2026
stuartcarnie
left a comment
Contributor
There was a problem hiding this comment.
Seems reasonable to me!
Contributor
|
Thanks! |
BendyLand
pushed a commit
to BendyLand/voltaire
that referenced
this pull request
Aug 2, 2026
…erministic-framework-macos [MacOS] Fix non-deterministic framework linking order on macOS for incremental builds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
On macOS, the order of
-frameworkflags in LINKFLAGS can vary between builds due to the use of unordered data structures forextra_frameworks. This causes the flags string generated from the SCons environment to change on every build invocation, even when there are no actual configuration changes.For module developers using external build systems (like Rake) that consume these flags, this results in:
Solution
Sort the
extra_frameworkslist before generating the framework linker flags to ensure a deterministic order.