Skip to content

LSP: Remove unread native_member_completions member #114442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Repiteo merged 1 commit into from
Jan 28, 2026
+0 −20
Merged

LSP: Remove unread native_member_completions member #114442

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion modules/gdscript/language_server/gdscript_language_protocol.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,6 @@ Dictionary GDScriptLanguageProtocol::initialize(const Dictionary &p_params) {

if (!_initialized) {
workspace->initialize();
text_document->initialize();
_initialized = true;
}

Expand Down
15 changes: 0 additions & 15 deletions modules/gdscript/language_server/gdscript_text_document.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,21 +122,6 @@ void GDScriptTextDocument::notify_client_show_symbol(const LSP::DocumentSymbol *
GDScriptLanguageProtocol::get_singleton()->notify_client("gdscript/show_native_symbol", symbol->to_json(true));
}

void GDScriptTextDocument::initialize() {
if (GDScriptLanguageProtocol::get_singleton()->is_smart_resolve_enabled()) {
for (const KeyValue<StringName, ClassMembers> &E : GDScriptLanguageProtocol::get_singleton()->get_workspace()->native_members) {
const ClassMembers &members = E.value;

for (const KeyValue<String, const LSP::DocumentSymbol *> &F : members) {
const LSP::DocumentSymbol *symbol = members.get(F.key);
LSP::CompletionItem item = symbol->make_completion_item();
item.data = JOIN_SYMBOLS(String(E.key), F.key);
native_member_completions.push_back(item.to_json());
}
}
}
}

Variant GDScriptTextDocument::nativeSymbol(const Dictionary &p_params) {
Variant ret;

Expand Down
4 changes: 0 additions & 4 deletions modules/gdscript/language_server/gdscript_text_document.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,6 @@ class GDScriptTextDocument : public RefCounted {

Ref<FileAccess> file_checker;

Array native_member_completions;

private:
Array find_symbols(const LSP::TextDocumentPositionParams &p_location, List<const LSP::DocumentSymbol *> &r_list);
void notify_client_show_symbol(const LSP::DocumentSymbol *symbol);
Expand Down Expand Up @@ -76,7 +74,5 @@ class GDScriptTextDocument : public RefCounted {
Variant declaration(const Dictionary &p_params);
Variant signatureHelp(const Dictionary &p_params);

void initialize();

GDScriptTextDocument();
};
Loading