Optimize core/input/input.h header #includeing#115360
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Jan 28, 2026
Merged
Optimize core/input/input.h header #includeing#115360Repiteo merged 1 commit intogodotengine:masterfrom
core/input/input.h header #includeing#115360Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
Repiteo
approved these changes
Jan 25, 2026
Contributor
Repiteo
left a comment
Repiteo
left a comment
There was a problem hiding this comment.
Oh wow, shifting around enum scope alone making this much of an impact is impressive!
AThousandShips
approved these changes
Jan 26, 2026
Nintorch
force-pushed
the
optimize-input-header-includes
branch
3 times, most recently
from
b31be62 to
4e79d48
Compare
Ivorforce
reviewed
Jan 26, 2026
Nintorch
force-pushed
the
optimize-input-header-includes
branch
from
4e79d48 to
5ed6dad
Compare
Member
|
This needs a rebase. |
Nintorch
force-pushed
the
optimize-input-header-includes
branch
from
5ed6dad to
0bd4944
Compare
Contributor
Author
|
Done! |
Nintorch
force-pushed
the
optimize-input-header-includes
branch
from
0bd4944 to
eb01951
Compare
Contributor
|
Thanks! |
Rubonnek
added a commit
to Rubonnek/limboai
that referenced
this pull request
Jan 29, 2026
Due to upstream change: godotengine/godot#115360
Rubonnek
added a commit
to Rubonnek/limboai
that referenced
this pull request
Feb 5, 2026
Due to upstream change: godotengine/godot#115360
rivie13
pushed a commit
to rivie13/Phoenix-Agentic-Engine
that referenced
this pull request
Feb 16, 2026
…ader-includes Optimize `core/input/input.h` header `#include`ing
Rubonnek
added a commit
to Rubonnek/limboai
that referenced
this pull request
Feb 18, 2026
Due to upstream change: godotengine/godot#115360
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR optimizes
#includeing ofinput.hheader.Each time I modify this header to improve an input feature I have to wait around 50 minutes (!) for the Windows editor to recompile, it's frustrating. 😅
That's why I decided to make this PR, so I (and other people that modify this file) won't have to wait too long.
I use GitHub CI to compile the engine (I think I don't have enough RAM to compile the engine on my laptop), and I think I can check the compilation times before and after this change.
I will compare between 2 CI runs, one of them was when I decided to rename the methods in my joypad motion sensors pr (
sensors->motion, so for example,has_joy_sensors()->has_joy_motion()) and the other one is a test change just to test the compilation times after this PR.Here are the results
So now the engine recompiles roughly 3-5 times faster when you edit
core/input/input.h! (Unless I'm misunderstanding something)