Fix BaseButton multitouch signals firing for only 1 button - #118608
Merged
Repiteo merged 1 commit intoApr 16, 2026
Conversation
3 tasks
Alex2782
approved these changes
Apr 15, 2026
Alex2782
left a comment
Alex2782
left a comment
Member
There was a problem hiding this comment.
Looks good! Tested on Android and macOS
Contributor
|
Thanks! |
BendyLand
pushed a commit
to BendyLand/voltaire
that referenced
this pull request
Aug 2, 2026
…ch-button-signals Fix BaseButton multitouch signals firing for only 1 button
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #118581.
Regression from #110893.
Multitouch
button_down/button_upsignals only fired for one button at a time. When a secondInputEventScreenTouchpress arrived on another button,on_action_event()rejected it becausestatus.hoveringis only set by mouse motion and the event was not treated as an accept event, sostatus.press_attemptnever became true and no signal was emitted.Also accept the press when the touch event targets a button whose
pressing_insideis already true(i.e. the touch that started inside the button's rect), so each button processes its own touch stream
independently and multiple buttons can emit
button_down/button_upsimultaneously.Verified on iOS Safari with a Web export of the MRP, pressing 4 buttons simultaneously with 4 fingers.
multitouch.mp4
Verified on Android Chrome
multitouch-android.mp4