Allow shader containers to be loaded in parallel. - #119123
Merged
Repiteo merged 1 commit intoJun 19, 2026
Merged
Conversation
blueskythlikesclouds
force-pushed
the
group-task-for-shader-cache-load
branch
from
April 30, 2026 17:50
ecee06d to
58a98cd
Compare
DarioSamo
approved these changes
May 4, 2026
DarioSamo
left a comment
DarioSamo
left a comment
Contributor
There was a problem hiding this comment.
Changes seem ok in general. There's no thread safety concerns as far as I can tell because all vectors are resized and initialized before any thread access happens. The existing compilation task system is also reused to load these variants from the cache, so generally this seems like it should unblock parallel loading even further.
Ivorforce
approved these changes
May 4, 2026
Ivorforce
left a comment
Ivorforce
left a comment
Member
There was a problem hiding this comment.
I authored the zstd caches to reduce RAM churn. Making it thread_local should be fine.
Can't comment on the rendering changes.
blueskythlikesclouds
force-pushed
the
group-task-for-shader-cache-load
branch
from
May 4, 2026 15:10
58a98cd to
d751f5b
Compare
Contributor
|
Thanks! |
Contributor
|
This is causing crashes on MacOS when using Metal: #120504 |
BendyLand
pushed a commit
to BendyLand/voltaire
that referenced
this pull request
Aug 2, 2026
…-task-for-shader-cache-load Allow shader containers to be loaded in parallel.
pirey0
pushed a commit
to Bippinbits/pvkk-godot
that referenced
this pull request
Aug 8, 2026
…-task-for-shader-cache-load Allow shader containers to be loaded in parallel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves #116228.
re-spirv parsing happens when loading shader containers. Previously, this operation happened completely sequentially, even when compiling shaders in multiple threads.
The following changes are done to allow it happen in parallel:
Testing the MRP from the issue with cached shaders and pipelines. Comparing
RendererSceneRenderImplementation::RenderForwardClustered::_render_scene:Before: 200 ms
After: 25 ms