Switch CSG tangent generation to meshopt_generateTangents - #120829
Merged
Conversation
Since CSGShape does not use SurfaceTool, we replicate the code to copy tangent inputs and generate tangents here directly; the CSG data is not indexed so we do not need any complex post-processing like vertex splitting. The time tangent generation takes during CSG operations tends to not be very significant but this ensures we use consistent tangent algorithm everywhere, and removes the dependency on mikktspace library.
BlueCube3310
approved these changes
Jul 3, 2026
Contributor
|
Thanks! |
BendyLand
pushed a commit
to BendyLand/voltaire
that referenced
this pull request
Aug 2, 2026
Switch CSG tangent generation to meshopt_generateTangents
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a followup to #119161 and replaces CSG tangent generation with the same algorithm.
Since CSGShape does not use SurfaceTool, we replicate the code to copy tangent inputs and generate tangents here directly; the CSG data is not indexed so we do not need any complex post-processing like vertex splitting.
The time tangent generation takes during CSG operations tends to not be very significant but this ensures we use consistent tangent algorithm everywhere, and removes the dependency on mikktspace library.
Tested using tangent visualization patch (https://github.com/user-attachments/files/24402824/tangent-debug.patch) but showing
binormalhere to ensure sign remains consistent too: