Don't always duplicate the image when validating the format. - #121020
Open
tdaven wants to merge 1 commit into
Open
Don't always duplicate the image when validating the format.#121020tdaven wants to merge 1 commit into
tdaven wants to merge 1 commit into
Conversation
This commit removes the image duplication that was present when validating a texture format. In most cases, the texture format is already compatible and supported so the duplication is unnessary. Now the duplication is only performed when the texture format is not supported and needs to be converted to a supported format.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes the image duplication that was present when validating a texture format. In most cases, the texture format is already compatible and supported so the duplication is unnecessary.
Now the duplication is only performed when the texture format is not supported and needs to be converted to a supported format.
This technically changes behavior a bit. If any of the callers depended on always getting a duplicate they would no longer get one. It didn't look like that was the case to me but I could have missed it.
This was a case I noticed while profiling my texture streaming pr (#113429).