[4.3] CI: Fix GitHub Action workflows - #121752
Merged
Merged
Conversation
Repiteo
approved these changes
Jul 25, 2026
Repiteo
left a comment
Contributor
There was a problem hiding this comment.
I was aiming for a more isolated implementation in those two PRs, but looking at how this was laid out, I think I prefer the more involved approach. Will go back and re-apply this format to those shortly
akien-mga
approved these changes
Aug 10, 2026
akien-mga
left a comment
Member
There was a problem hiding this comment.
Looks good to me, thanks for doing this update for old branches.
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes several problems that occur on the GitHub Actions CI checks when compiling the 4.3 branch.
Note: I am aware that the Godot maintainers have told me to stop touching old Godot branches. However, I believe "making it compile" should still be in the scope of support (so, basically zero support, but not quite zero). See also PRs #121604 and #121603 for fixing the 4.4 and 4.5 branches.
Namely, it cherry-picks the following commits and PRs:
macos-latest.windows-latestand MSVC for Visual Studio 2026.-Wunnecessary-virtual-specifierwerror=yes.dotnet formatstep inpre-commit run --all-files.