Skip to content

[4.3] CI: Fix GitHub Action workflows - #121752

Merged
Repiteo merged 7 commits into
godotengine:4.3from
aaronfranke:fix-4.3-ci
Aug 13, 2026
Merged

[4.3] CI: Fix GitHub Action workflows #121752
Repiteo merged 7 commits into
godotengine:4.3from
aaronfranke:fix-4.3-ci

Conversation

@aaronfranke

@aaronfranke aaronfranke commented Jul 25, 2026

Copy link
Copy Markdown
Member

This PR fixes several problems that occur on the GitHub Actions CI checks when compiling the 4.3 branch.

Note: I am aware that the Godot maintainers have told me to stop touching old Godot branches. However, I believe "making it compile" should still be in the scope of support (so, basically zero support, but not quite zero). See also PRs #121604 and #121603 for fixing the 4.4 and 4.5 branches.

Namely, it cherry-picks the following commits and PRs:

@aaronfranke aaronfranke added this to the 4.3 milestone Jul 25, 2026

@Repiteo Repiteo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was aiming for a more isolated implementation in those two PRs, but looking at how this was laid out, I think I prefer the more involved approach. Will go back and re-apply this format to those shortly

@akien-mga akien-mga left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for doing this update for old branches.

@Repiteo
Repiteo merged commit 24f8d6e into godotengine:4.3 Aug 13, 2026
19 checks passed
@Repiteo

Repiteo commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Thanks!

@aaronfranke
aaronfranke deleted the fix-4.3-ci branch August 13, 2026 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants