[Project Manager] Fix Wrap Long Project Title and Compact Mode

[CarrotOfPower]

• Closes Project Manager UI breaks when adding project to list #122075
• Actually closes 4.8 Master [457470a] Project Manager UI breaks when shrinking #122092
• Fixes Memory leak when resizing the Project Manager to minimum width #122257
• Fixes index reuse error noted in PR [ProjectList] Fix title index handling on refresh #122037
• Supersedes Various Fixes for Project Title Wrapping #122095
• Supersedes Project Manager: Add Compact Mode Setting #122152
• Introduced in Editor: Wrap Long Project Title #119580 and Android editor: Enable screen orientation change on large screens and in Project Manager #121387

This is meant for 4.8. You can find the fix for 4.7.2 here: #122350.

What problem(s) does this PR solve?

• This PR fixes all issues with wrapping project titles and compact mode. For more info, see the two suspended PRs.
• Simplifies logic significantly while maintaining the same functionality, fixing issues with long project titles not wrapping correctly.
• Replaces the magic number former used for title_size_cache through logic, so the value is calculated and save for future layout changes, while the magic number had to be adjusted for layout changes.
• Should work on any scale now.
• Implements compact mode setting like explained in Project Manager: Add Compact Mode Setting #122152.

#122075

wrap_long_project_title_empty_tag_container_bug.mp4

#122092

The bug in that issue was caused by #121387 as it introduced a compact mode which hid the sidebar when the project manager was shrunk beyond a threshold. This PR does two things:

• Adds Compact Mode setting: project_manager/compact_mode.
• Adds Compact Mode Threshold setting: project_manager/compact_mode_threshold, which sets the point to hide the project manager sidebar.

Reasoning

Since the mentioned PR was andriod focused, a compact mode setting builds upon the PR, it is set to on by default on the intended mobile devices and off on desktop devices.
Because desktop devices have more real-estate, the compact_mode_threshold gives users more fine grained control.

(This text is from #122152)

Difference to #122152 / #122095

• Fixes multiple bugs contained in Project Manager: Add Compact Mode Setting #122152 / Various Fixes for Project Title Wrapping #122095 (when I write this).
• Project Manager: Add Compact Mode Setting #122152 / Various Fixes for Project Title Wrapping #122095 do NOT fix Memory leak when resizing the Project Manager to minimum width #122257.
• This PR replaces the magic number former used for title_size_cache through logic, so the value is calculated and save for future layout changes, while the magic number had to be adjusted for layout changes.
• Some Optimizations, which also makes the code cleaner to read.
• The behaviour itself. Here a demo:

This is #122152:

project-manager-add-compact-mode.mp4

As you may notice, the tags do not resize at first, title and tags share the space somewhere in the middle.
Also, you see the errors from #122257 in the terminal window.

This PR:

fix-wrap-long-project-title-result-scale-2.2-demo.mp4

It ensures that the tags do resize at first, so the title can take mor space, which can be used more efficiently.
You don't see any errors in the terminal window.

Also, #122152 currently broke the compact mode setting. For demo:

#122152:

project-manager-add-compact-mode-setting-applied-compact-mode-bug.mp4

This PR:

fix-wrap-long-project-title-result-scale-2.2-compact-mode-demo.mp4

Additional information

Validated by building the Windows editor with SCons and testing it, as well as testing the test artifact for Windows.

[unit-tick]

The tags are already taken into account in set_project_title_autowrap. They are added to the tag_size_cache. This PR isn't needed, also, I'm unable to reproduce your error on my end.

[CarrotOfPower]

The tags are already taken into account in set_project_title_autowrap. They are added to the tag_size_cache. This PR isn't needed, also, I'm unable to reproduce your error on my end.

Strange...

My system info is: Godot v4.8.dev2 - Windows 11 (build 26200) - Multi-window, 1 monitor - Direct3D 12 (Forward+) - dedicated AMD Radeon 780M Graphics (Advanced Micro Devices, Inc.; 32.0.13018.6) - AMD Ryzen 7 8700G w/ Radeon 780M Graphics (16 threads) - 31.11 GiB memory - WASAPI (48000 Hz, Stereo/mono)

I've set interface/editor/appearance/
custom_display_scale to 2.2

Anyway, this fixes the bug for me.

[unit-tick]

I'm genuinely confused. I tested this at all standard editor scales before pushing the change and it worked perfectly. Now it barely works at 1.25 and breaks completely at any scale above 1.5. I tried implementing your change in my custom build and it's still broken and somehow your build broke and is staying broken. I'll have to look into it.

[unit-tick]

@Anyone4551, I managed to get a fix that works on my end and in my testing found another bug. If you don't mind I would like to create a PR that includes the fix for this bug, the fix for the other bug, and your last fix #122037. Would also make the changes easier to cherrypick for 4.7.2. You'll be added as a Co-Author, it's also fine if you prefer not to, it's up to you.

[unit-tick]

This works on my end, also doesn't break when opened with a single tag, which your previous changes did.

[CarrotOfPower]

@unit-tick Yes! It works. Of course, you can create a PR yourself. Finally, You fixed it. Nevertheless, I updated this one.
By the way: That's a great feature you've implemented.

[unit-tick]

Tested this fix and it doesn't work at 0.75 editor scale, which means it does not fix #122092, so that needs to be removed so a proper fix can be made for it.

UI.clipping.0.75.scale.mp4

[CarrotOfPower]

@AThousandShips Since I cannot find a "Request for Review" button, I would like to ask you for a review.

[AThousandShips]

I don't really have anything to add