Skip to content

[4.4] Fix indentation in Dictionary.xml code blocks - #122356

Merged
Repiteo merged 1 commit into
godotengine:4.4from
aaronfranke:4.4-fix-dict-xml-indent
Aug 13, 2026
Merged

[4.4] Fix indentation in Dictionary.xml code blocks#122356
Repiteo merged 1 commit into
godotengine:4.4from
aaronfranke:4.4-fix-dict-xml-indent

Conversation

@aaronfranke

Copy link
Copy Markdown
Member

The 4.4 branch (and only the 4.4 branch) was failing CI due to make_rst.py erroring on Dictionary.xml:

  ERROR: Dictionary.xml: Four spaces should be used for indentation within [gdscript].
  ERROR: Dictionary.xml: Four spaces should be used for indentation within [csharp].

This is because PR #107071 was cherry-picked for Godot 4.4 here, but the 4.4 branch does not have the ability to use tabs in code blocks. That ability was introduced in PR #89819 for Godot 4.5.

CC @Repiteo, this should be a very fast approval, it's a trivial fix.

@aaronfranke aaronfranke added this to the 4.4 milestone Aug 12, 2026
@aaronfranke
aaronfranke requested a review from Repiteo August 12, 2026 23:58
@Repiteo
Repiteo merged commit b3f9d43 into godotengine:4.4 Aug 13, 2026
20 checks passed
@Repiteo

Repiteo commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Thanks!

@aaronfranke
aaronfranke deleted the 4.4-fix-dict-xml-indent branch August 13, 2026 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants