Skip to content

Fixed renaming/reparenting/duplicating a node disabling editable_children - #20607

Closed
Piet-G wants to merge 3 commits into
godotengine:masterfrom
Piet-G:duplicatable_editable_children
Closed

Fixed renaming/reparenting/duplicating a node disabling editable_children#20607
Piet-G wants to merge 3 commits into
godotengine:masterfrom
Piet-G:duplicatable_editable_children

Conversation

@Piet-G

@Piet-G Piet-G commented Jul 30, 2018

Copy link
Copy Markdown
Contributor

Fixed renaming/reparenting/duplicating a node disabling editable_children.

This should fix #20409 & fix #6455 and probably some others I missed.

@Piet-G
Piet-G requested a review from reduz as a code owner July 30, 2018 16:47
@Piet-G Piet-G changed the title Fixed renaming a node disabling editable_children Fixed renaming/reparenting/duplicating a node disabling editable_children Jul 30, 2018
@akien-mga akien-mga added this to the 3.1 milestone Aug 13, 2018
@reduz

reduz commented Aug 14, 2018

Copy link
Copy Markdown
Member

This is a really difficult issue to fix without introducing many hacks, and we are too close to 3.1 alpha to risk breaking more things.
Eventually plan is for next version to re-evaluate how all this data is stored in hopes of simplifying the system.

@reduz reduz modified the milestones: 3.1, 3.2 Aug 14, 2018
@Piet-G

Piet-G commented Aug 14, 2018

Copy link
Copy Markdown
Contributor Author

Yeah currently it seems almost impossible to solve this problem without a bunch of hacks with the current way the editable_children data is stored.

@akien-mga

Copy link
Copy Markdown
Member

Sorry for the lack of update in over a year :|

I'm unsure on how to proceed with this PR. There are various issues with the approach uses, especially the fact that it adds many new methods and signals to the public node API which have no real reason to be in the public API. As @reduz mentioned, the approach used is a bit hacky, but a non-hacky solution is likely difficult to use right now.

I think this PR should likely be closed, but we need to have some pointers on how the two referenced bugs should be fixed in a clearer manner. Especially whether any fix should wait on:

Eventually plan is for next version to re-evaluate how all this data is stored in hopes of simplifying the system.

And when would this happen in the roadmap.

@akien-mga akien-mga modified the milestones: 3.2, 4.0 Oct 4, 2019
@aaronfranke

Copy link
Copy Markdown
Member

@Piet-G Is this still desired? If so, it needs to be rebased on the latest master branch.

If not, abandoned pull requests will be closed in the future as announced here.

@aaronfranke

Copy link
Copy Markdown
Member

This PR has not received any new commits for almost 2 years and is abandoned, closing.

The "salvageable" tag applies, anyone is welcome to take this PR and update/finish it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename an "Instanced Scene as Node" disables "Editable Children" Instance loses it's "Editable children" flag after renaming. Affects saved edits too

5 participants