Skip to content

Added copy constructor for various built-in types. - #24080

Closed
vinterskog wants to merge 1 commit into
godotengine:masterfrom
vinterskog:bugfixes
Closed

Added copy constructor for various built-in types.#24080
vinterskog wants to merge 1 commit into
godotengine:masterfrom
vinterskog:bugfixes

Conversation

@vinterskog

@vinterskog vinterskog commented Nov 30, 2018 •
edited by Chaosus
Loading

Copy link
Copy Markdown

bugsquad edit: Fixes #24001

@vinterskog
vinterskog requested a review from reduz as a code owner November 30, 2018 09:32
@Chaosus Chaosus changed the title Added copy constructor for various built-in types. Fixes #24001. Added copy constructor for various built-in types. Nov 30, 2018
@Chaosus Chaosus added this to the 3.1 milestone Nov 30, 2018
@akien-mga

akien-mga commented Dec 4, 2018

Copy link
Copy Markdown
Member

There are build and style issues: https://travis-ci.org/godotengine/godot/builds/461693498

@akien-mga

akien-mga commented Dec 4, 2018

Copy link
Copy Markdown
Member

See PR workflow for instructions on how to rebase your branch properly to remove the unrelated commits (and eventually squash the fixups).

@vinterskog
vinterskog force-pushed the bugfixes branch 2 times, most recently from 34ff8aa to 026ca10 Compare December 4, 2018 17:07
aaronfranke
aaronfranke requested changes Dec 6, 2018
View reviewed changes
Comment thread core/math/vector3.h Outdated
Comment thread core/color.h Outdated
@akien-mga

akien-mga commented Dec 6, 2018

Copy link
Copy Markdown
Member

Could you squash commits together? See PR workflow.

@vinterskog

vinterskog commented Dec 6, 2018

Copy link
Copy Markdown
Author

I think I did it. Hopefully. :D

aaronfranke
aaronfranke requested changes Dec 6, 2018
View reviewed changes
Comment thread core/variant_call.cpp Outdated
@akien-mga

akien-mga commented Dec 12, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

Moving to 3.2 milestone as we're about to enter the beta stage and release freeze for Godot 3.1. Only bug fixes against issues of the 3.1 milestone (or enhancements to core features of the 3.1 roadmap) will be considered until 3.1-stable is released.

Note: If it's merged after 3.1-stable is released, this change may be considered for cherry-picking into a later 3.1.x release.

@akien-mga akien-mga modified the milestones: 3.1, 3.2 Dec 12, 2018
@akien-mga akien-mga modified the milestones: 3.2, 4.0 Nov 7, 2019
@aaronfranke

aaronfranke commented Jan 17, 2020

Copy link
Copy Markdown
Member

This is most likely entirely superseded by #34948, so this should probably be closed. @vinterskog If there is anything else in this PR that is still necessary, let us know.

@aaronfranke

aaronfranke commented May 13, 2020

Copy link
Copy Markdown
Member

Closing as superseded by #34948.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akien-mga akien-mga akien-mga left review comments
@aaronfranke aaronfranke aaronfranke requested changes
@reduz reduz Awaiting requested review from reduz

Assignees

No one assigned

Labels

archived enhancement topic:core

Projects

None yet

Milestone

4.0

Development

Successfully merging this pull request may close these issues.

Vector2(position) constructor causes an error

6 participants

@vinterskog @akien-mga @aaronfranke @Calinou @mhilbrunner @Chaosus