Skip to content

[3.x] Fix NavigationObstacle errors - #56600

Merged
akien-mga merged 1 commit into
godotengine:3.xfrom
Scony:fix-navigation-obstacle-errors-3.x
Jan 28, 2022
Merged

[3.x] Fix NavigationObstacle errors#56600
akien-mga merged 1 commit into
godotengine:3.xfrom
Scony:fix-navigation-obstacle-errors-3.x

Conversation

@Scony

@Scony Scony commented Jan 7, 2022

Copy link
Copy Markdown
Contributor

Fixes part of #57254

  • Typo in error print leading to false-positive message
  • NavigationObstacle premature radius estimation (before entering the tree)
  • NavigationObstacle2D premature radius estimation (before entering the tree)

Which are the problems introduced in navigation backport: #48395

@Scony
Scony requested a review from a team as a code owner January 7, 2022 18:12
@Scony Scony changed the title Fix NavigationObstacle errors [3.x] Fix NavigationObstacle errors Jan 7, 2022
@Calinou Calinou added this to the 3.5 milestone Jan 7, 2022
* Typo in error print leading to false-positive message
* `NavigationObstacle` premature radius estimation (before entering the tree)
* `NavigationObstacle2D` premature radius estimation (before entering the tree)
@Scony
Scony force-pushed the fix-navigation-obstacle-errors-3.x branch from bcc9ae4 to 6093d59 Compare January 7, 2022 19:05
@Scony
Scony requested a review from a team as a code owner January 7, 2022 19:05
@akien-mga
akien-mga requested review from a team and removed request for a team January 7, 2022 19:44
@akien-mga
akien-mga merged commit 9cdd110 into godotengine:3.x Jan 28, 2022
@akien-mga

Copy link
Copy Markdown
Member

Thanks!

@akien-mga

Copy link
Copy Markdown
Member

At least some of these changes seem like they could be relevant for master too.

@Scony

Scony commented Jan 28, 2022

Copy link
Copy Markdown
Contributor Author

yep, they're in #56601

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants