doc: Use Signal.emit instead of emit_signal in Object examples

[kkoang]

Change the code and use the new method of godot4

URL:https://docs.godotengine.org/en/latest/classes/class_object.html

[Mickeon]

This PR tries changes the function shown in the examples of Object.emit_signal() itself to use Signal.emit() which is not what is being described. Last time I took a look at this description, I thought that this entire set of paragraphs should be stripped away instead, and moved somewhere else, at best. The entire thing is needlessly long and verbose.

[YuriSizov]

This PR tries changes the function shown in the examples of Object.emit_signal() itself to use Signal.emit() which is not what is being described.

Well, we're using Signal's API for connecting and disconnecting, for example. So I think this change is valid.

this entire set of paragraphs should be stripped away instead, and moved somewhere else, at best. The entire thing is needlessly long and verbose.

You are probably right there.

[mhilbrunner]

I think this change is good by itself, regardless of possible further improvements of the whole section. Moving away from strings in favor of signal names wherever we can in examples is good, IMO.

Unfortunately, this needs a rebase.

[akien-mga]

Rebased, and gave the PR and commit a meaningful title.

Would be good that @godotengine/dotnet checks that the C# example is correct.

[paulloz]

Hi. Nope, this does not work in C#. Currently, the only way to emit signals is through EmitSignal (see https://docs.godotengine.org/en/latest/tutorials/scripting/c_sharp/c_sharp_signals.html#signal-emission). There are WIPs to have access to a strongly typed API (#68233), but it is not merged at the moment.

[kkoang]

@paulloz I restored the C# code to its original state. Sorry, I’m not familiar with C#.

[akien-mga]

Looks good! Could you squash the commits? See PR workflow for instructions.

Edit: Done myself.

[kkoang]

@akien-mga I am not a professional programmer. I have been reading PR workflow and learning git, and it may take a few days. If you have already helped me complete the "rebase", I am very grateful.😊

[akien-mga]

Yes it's all good now :) I'll merge this soon.

[akien-mga]

Thanks! And congrats for your first merged Godot contribution 🎉

And apologies for the delay getting this reviewed.