Tweak environment in the Advanced Import Settings dialog - #75787
Merged
akien-mga merged 1 commit intoApr 13, 2024
Merged
Conversation
smix8
reviewed
Apr 7, 2023
Use a gradient sky to improve visibility in shaded areas, while also helping the user orient themselves. The bottom of the sky is black, while the top of the sky is white. This change also makes it so that the Default Clear Color project setting no longer affects the Advanced Import Settings dialog.
Calinou
force-pushed
the
advanced-import-settings-tweak-environment
branch
from
April 8, 2024 23:04
1bdf216 to
7259985
Compare
smix8
approved these changes
Apr 13, 2024
smix8
left a comment
smix8
left a comment
Contributor
There was a problem hiding this comment.
While all other prs that touch the preview are stuck in fix-me or bike-shed hell this PR fixes the immediate issue that you can not see your rotated asset on a 100% grey backdrop. Everything else can still be improved later.
lyuma
approved these changes
Apr 13, 2024
lyuma
left a comment
lyuma
left a comment
Contributor
There was a problem hiding this comment.
Heck yes!
Congratulations on a happy one year PRnniversary.
I have no idea how this flew under the radar, but let's get this in for 4.3!
Member
|
Thanks! |
BendyLand
pushed a commit
to BendyLand/voltaire
that referenced
this pull request
Aug 2, 2026
…tings-tweak-environment Tweak environment in the Advanced Import Settings dialog
BendyLand
pushed a commit
to BendyLand/voltaire
that referenced
this pull request
Aug 2, 2026
…tings-tweak-environment Tweak environment in the Advanced Import Settings dialog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a gradient sky to improve visibility in shaded areas, while also helping the user orient themselves. The bottom of the sky is black, while the top of the sky is white.
This change also makes it so that the Default Clear Color project setting no longer affects the Advanced Import Settings dialog.
If we agree upon this change, a similar change can be made to mesh and material previews in the inspector.
Testing project: test_advanced_import_settings_preview.zip
Preview
Notice how you can actually distinguish shaded areas from each other now.