Add secondary light to 3D Advanced Import Settings - #76140
Conversation
f85d165 to
616a767
Compare
616a767 to
d2357a1
Compare
7595a32 to
47cd8e4
Compare
|
Tested. I noticed that the two lights are coming from similar angles, one more on top and one more on the side. However, the material preview has light coming from very different angles, one light in the bottom and one light in the top right. Since one of the goals is to resemble that editor, shouldn't one of the lights be coming from below? Also, in the material preview, the lights stay fixed relative to the camera. In this PR, the lights are fixed relative to the object. I think it would be better to have lights fixed relative to the camera, so you can view different parts of the model illuminated by the light at different angles relative to the model, instead of having a fixed part of the model lit at the same angle relative to the model. |
Co-authored-by: Aaron Franke <arnfranke@yahoo.com>
47cd8e4 to
c3bc768
Compare
|
Since the original author was inactive, I sent them an email asking for write access to their repo so I can push to their PRs, which they granted to me. I have taken over this PR in order to bring it to the finish line. Most of the code is still Jeronimo's work, which is itself similar to the mesh and material previewer code, so I have him marked as author. I made the following changes to this PR:
This new button uses a new icon called "PreviewRotate", which is the same as "ToolRotate" but with an outline and brighter (thank you to @MewPurPur for making this). |
fire
left a comment
There was a problem hiding this comment.
I am ok with adding the enhancement to add a secondary light. Did not compile the code.
|
Thanks! |
…dary_light_to_3d_resource_importer Added secondary light to 3D Advanced Import Settings
…dary_light_to_3d_resource_importer Added secondary light to 3D Advanced Import Settings


Added a second light for the 3D Preview Viewport and UI toggle buttons which resemble the ones in the EditorMaterialPreviewPlugin
On branch add_secondary_light_to_3d_resource_importer
Changes to be committed:
modified: editor/import/scene_import_settings.cpp
modified: editor/import/scene_import_settings.h