C#: Add option to embed dotnet build outputs into the data file - #76305
Merged
Conversation
RedworkDE
force-pushed
the
net-build-output-embed
branch
from
June 28, 2023 20:20
9182e90 to
777d959
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #73257. Somewhat related issue: #72159
This is largely equivalent to the
mono/export/export_assemblies_inside_pckproject setting from 3.x.Adds an export option that, when enabled, embeds the C# build outputs into the pck/zip instead of having them as loose files. For execution these files have to be extracted to some temporary location to be able to load them.
Together with the embed pck option this allows for single file exports of C# project for windows and linux.
Open Question: What is the best place to put the published outputs for execution?
Currently they are extracted into
OS::get_singleton()->get_cache_path().path_join("data_" + appname_safe + "_" + arch), which on windows ends up inAppData/Localwhich is not a folder that can really be cleaned out as per user app installations often end up there and thus these files are likely to remain there forever.