Add function ZIPReader::file_exists - #76860
Merged
Merged
Conversation
Contributor
|
Thanks, this helps a lot! Before (Godot 4.0.2): After compiling the editor from this PR and changing my code to use |
Member
Author
|
Thank you for providing a benchmark example |
AThousandShips
force-pushed
the
zip_file_exists
branch
from
August 16, 2023 12:02
54b66df to
357efaf
Compare
akien-mga
reviewed
Aug 16, 2023
AThousandShips
force-pushed
the
zip_file_exists
branch
from
August 16, 2023 13:10
357efaf to
f7fa72c
Compare
Member
|
Thanks! |
Member
Author
|
Thank you! |
BendyLand
pushed a commit
to BendyLand/voltaire
that referenced
this pull request
Aug 2, 2026
Add function `ZIPReader::file_exists`
BendyLand
pushed a commit
to BendyLand/voltaire
that referenced
this pull request
Aug 2, 2026
Add function `ZIPReader::file_exists`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: godotengine/godot-proposals#6834
I assumed it should consider a file it can find but not open as it not existing, essentially as a "will it make
read_filenot throw an error"