Additional cleanup of bone editors - #77096
Merged
akien-mga merged 1 commit intoAug 17, 2023
Merged
Conversation
As discussed in the editor channel in RC, additional cleanup for BoneTransformEditor to move editor creation in construction and access theme in NOTIFICATION_THEME_CHANGED
spanzeri
changed the title
YuriSizov
approved these changes
Aug 4, 2023
YuriSizov
left a comment
YuriSizov
left a comment
Contributor
There was a problem hiding this comment.
Theming side of things makes sense. I would appreciate a review from @godotengine/animation.
Member
Didn't happen so far, but since it's purely theming / editor UI changes, I think your review is sufficient. |
Member
|
Thanks! |
BendyLand
pushed a commit
to BendyLand/voltaire
that referenced
this pull request
Aug 2, 2026
…eanup-followup Additional cleanup of bone editors
BendyLand
pushed a commit
to BendyLand/voltaire
that referenced
this pull request
Aug 2, 2026
…eanup-followup Additional cleanup of bone editors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in rocket chat, this is the follow up of: #77074
BoneTransformEditor::create_editor is called from the constructor rather than NOTIFICATION_ENTER_TREE and the background color for EditorInspectSections are updated on theme change.