Fix push_input events not going through after first pressed mouse event - #77730
Conversation
|
This PR was discussed in a recent Input-PR review meeting together with #77926. |
|
This PR should be considered for 4.2 as a non-compatibility breaking alternative to #77926. |
AThousandShips
left a comment
There was a problem hiding this comment.
Simplification suggestion
Subviewports didn't update their parent's local_input_handled correctly. Fixes godotengine#76439.
a4aa6d7 to
7957354
Compare
Sauermann
left a comment
There was a problem hiding this comment.
I have verified the problem of the linked issue and verified, that the MRP accurately represents the problem.
The MRP is still a problem in current master and this PR (rebased on [b9a3bd2]) solves the problem.
The code is in alignment with preexisting code
Lines 3657 to 3673 in d76c1d0
While I believe that #77926 (removal of handle_input_locally) is a better solution in the long term, I consider it unlikely that it will get reviews in the near future, so at the moment the best approach to fix the linked issue is this PR.
|
Thanks! |
Fix `push_input` events not going through after first pressed mouse event
Fix `push_input` events not going through after first pressed mouse event
Subviewports didn't update their parent's local_input_handled correctly.
The patch is basically the inverse of
set_input_as_handled.There is a small chance that this change is not the way to fix the issue, but it didn't create any problems in my case.
Fixes #76439.
Off-topic: Wow, that's some fast CI! Thanks Akien!